Xero Create a Quote has blank Terms from Branding Theme. Why?

Features
1

I am using the Make.com module, Create a Quote.

When generating a Quote I am selecting the Branding Theme. That theme has Terms set up on it.

I can see in the resulting quote draft on Xero that the Branding Theme is selected and applied. However, I note that the terms set on the Branding Theme do not come through on the quote. It has an empty Terms text entry box waiting to be filled out on the draft quote, and the PDF has no terms on it.

When generating invoices via Make.com this issue does not occur. The terms from the Branding Theme come through just fine.

Is this expected behaviour in the Xero API for Quotes? Or is this an issue with the Make.com Xero Create a Quote module? For example, is it submitting a “blank” terms field that is overriding the terms from the Branding Theme?

3

I’ve now done a comparison of the Output Bundle on the Create a Quote module and the Create an Invoice module.

I see that in the Quote module there is a Terms key with an empty value in the JSON (i.e. "Terms": "". I suspect this is the issue—that this is causing the API to override the terms that would otherwise be pulled in from the Branding Theme.

In the Invoice output bundle there is no Terms key in the JSON.

[
    {
        "QuoteID": "8ee83baa-5edb-43b4-91b1-348a6c54ccd3",
        "QuoteNumber": "QU-4016",
        "Reference": "Test Test Test",
        "Terms": "",
        "Contact": {
            "ContactID": "32ff650e-2281-4da1-a45d-462301070814",
            "Name": "Joes Construction Test",

The input bundle for this quote test had no key or value for Terms. Yet it shows up in the output bundle that is submitted to the Xero API.

I get the impression this is a bug in the Create a Quote module.

4

Make.com have confirmed this is not an issue from within Make. The Create a Quote module is not inadvertently sending the Xero API an Terms key with an empty value. If the Terms field has no data in it, it is excluded from the JSON submitted.

However, the Xero API is returning a response that then has the Terms key along with a null value for it.

I have taken the matter up with Xero. Awaiting a reply from them.

1 Like